Skip to content

Reformat source files using black #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

Reformat source files using black #76

merged 1 commit into from
Oct 4, 2024

Conversation

maximevaillancourt
Copy link
Contributor

@maximevaillancourt maximevaillancourt commented Oct 4, 2024 •
edited
Loading

What

Run black on the library's Python source files:

All done! ✨ 🍰 ✨                                                                                                                                                                         
47 files reformatted, 14 files left unchanged.

Why

To pass the continuous integration lint check, which currently fails with the following message:

Oh no! 💥 💔 💥
47 files would be reformatted, 14 files would be left unchanged.

SDK Release Checklist

I don't believe this change requires bumping the package version since this should be behaviour no-op.

@maximevaillancourt maximevaillancourt marked this pull request as ready for review October 4, 2024 17:52
pcothenet
pcothenet approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@pcothenet pcothenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maximevaillancourt . Agree on this being a no-op

@maximevaillancourt maximevaillancourt merged commit 44d1ea0 into main Oct 4, 2024
2 checks passed
@maximevaillancourt maximevaillancourt deleted the mv/lint branch October 4, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcothenet pcothenet pcothenet approved these changes

@holtbp holtbp Awaiting requested review from holtbp

@venalen venalen Awaiting requested review from venalen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maximevaillancourt @pcothenet